Expose refresh token via extension and add CacheOptions.DisableInternalCache by Robbie-Microsoft · Pull Request #5947 · AzureAD/microsoft-authentication-library-for-dotnet

Robbie-Microsoft · 2026-04-23T21:25:10Z

Summary

Implements #5942

Deliverable 1: Expose refresh token via extension method

Added internal string RefreshToken { get; set; } to AuthenticationResult
Populated it in RequestBase.CacheTokenResponseAndCreateAuthenticationResultAsync
Created public AuthenticationResultExtensions.GetRefreshToken() extension method in src/client/Microsoft.Identity.Client/Extensibility/

Deliverable 2: `CacheOptions.DisableInternalCacheOptions`

Added IsInternalCacheDisabled bool property to CacheOptions
Added DisableInternalCacheOptions static factory property to CacheOptions
Guarded all token cache writes (SaveTokenResponseAsync) behind !IsInternalCacheDisabled
Skipped cache reads in CacheSessionManager.Find*Async when disabled
GetInternalCacheEntryCountForTelemetry() returns 0 instead of reading Accessor.EntryCount when disabled
Populates Account.TenantProfiles from the freshly received ID token (no accessor reads) when disabled
Added early-throw in CacheSilentStrategy.ExecuteAsync with MsalError.InternalCacheDisabled
Added mutual exclusivity validation in AbstractApplicationBuilder.WithCacheOptions
Consolidated CacheRefreshReason.CacheDisabled telemetry assignment in OnBehalfOfRequest.cs
AcquireTokenInLongRunningProcess throws MsalUiRequiredException(InternalCacheDisabled) when cache is disabled (surfaces root cause instead of confusing OboCacheKeyNotInCacheError)

Other changes

MsalError.InternalCacheDisabled = "internal_cache_disabled" error code
MsalErrorMessage.InternalCacheDisabledMessage with guidance toward AcquireTokenByRefreshToken
All 6 PublicAPI.Unshipped.txt files updated with new API surface
Added internal static CacheOptions.IsDisabledFor(CacheOptions) helper — centralizes the null-safe IsInternalCacheDisabled check used in RequestBase, CacheSessionManager, CacheSilentStrategy, and TokenCache
Added protected RequestBase.IsInternalCacheDisabled property so request subclasses (OnBehalfOfRequest, ClientCredentialRequest) use a single expression instead of repeating the verbose pattern
Collapsed the two sequential IsInternalCacheDisabled branches in OnBehalfOfRequest into one block
Updated CacheOptions.IsInternalCacheDisabled and DisableInternalCacheOptions XML docs to document all throwing behaviors

Tests

InternalCacheOptionsTests.cs: 14 tests covering all acceptance criteria, including GetRefreshToken() null assertion for client credentials (server never issues RTs for client_credentials grant)
HttpTelemetryTests.cs: 3 new tests verifying CacheRefreshReason.CacheDisabled in x-client-current-telemetry header (ATFC, OBO, InitiateLongRunningObo)
OTelInstrumentationTests.cs: 2 new tests verifying CacheRefreshReason.CacheDisabled in OTel MsalSuccess metric tags (ATFC, OBO)

Copilot

Pull request overview

This PR implements issue #5942 by (1) exposing the refresh token from AuthenticationResult via a public extension method (without adding it to the public AuthenticationResult API surface) and (2) adding CacheOptions.DisableInternalCache / InternalCacheDisabled to allow callers to bypass MSAL’s internal token cache behavior.

Changes:

Added an internal AuthenticationResult.RefreshToken field, populated during result creation, and exposed via AuthenticationResultExtensions.GetRefreshToken().
Introduced CacheOptions.InternalCacheDisabled + CacheOptions.DisableInternalCache, guarded cache writes, skipped key cache reads, and made AcquireTokenSilent throw a dedicated error when the internal cache is disabled.
Updated PublicAPI “Unshipped” files and added unit tests for the new behaviors.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/Microsoft.Identity.Test.Unit/CacheTests/InternalCacheOptionsTests.cs	Adds tests for refresh token exposure and disabling internal cache behavior.
src/client/Microsoft.Identity.Client/AuthenticationResult.cs	Adds internal `RefreshToken` property to hold RT from token response.
src/client/Microsoft.Identity.Client/Internal/Requests/RequestBase.cs	Populates `AuthenticationResult.RefreshToken` from the token response.
src/client/Microsoft.Identity.Client/Extensibility/AuthenticationResultExtensions.cs	Adds public `GetRefreshToken()` extension method.
src/client/Microsoft.Identity.Client/AppConfig/CacheOptions.cs	Adds `InternalCacheDisabled` and `DisableInternalCache`.
src/client/Microsoft.Identity.Client/AppConfig/AbstractApplicationBuilder.cs	Validates mutual exclusivity of `UseSharedCache` vs `InternalCacheDisabled`.
src/client/Microsoft.Identity.Client/Internal/Requests/Silent/CacheSilentStrategy.cs	Throws `internal_cache_disabled` when `AcquireTokenSilent` is used with disabled cache.
src/client/Microsoft.Identity.Client/Cache/CacheSessionManager.cs	Skips certain cache lookups when internal cache is disabled.
src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs	Skips internal cache writes and serialization events when internal cache is disabled.
src/client/Microsoft.Identity.Client/MsalError.cs	Adds `MsalError.InternalCacheDisabled` error code.
src/client/Microsoft.Identity.Client/MsalErrorMessage.cs	Adds guidance message for the new error.
src/client/Microsoft.Identity.Client/PublicApi/*/PublicAPI.Unshipped.txt	Tracks the newly added public API surface across TFMs.

bgavrilMS

Approved with a comment

gladjohn

can we add an integration test?

Copilot

Pull request overview

Implements feature request #5942 by (1) exposing the refresh token via a public extension method without adding it to AuthenticationResult’s public surface, and (2) adding CacheOptions.DisableInternalCache to fully disable MSAL’s internal token cache (reads + writes) and make AcquireTokenSilent fail fast with a descriptive error.

Changes:

Added AuthenticationResultExtensions.GetRefreshToken() backed by a new internal AuthenticationResult.RefreshToken populated from token responses.
Introduced CacheOptions.InternalCacheDisabled / CacheOptions.DisableInternalCache and enforced behavior across cache read/write paths plus AcquireTokenSilent.
Updated PublicAPI analyzer baselines and added/updated unit + integration tests for the new behavior.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/Microsoft.Identity.Test.Unit/CacheTests/InternalCacheOptionsTests.cs	Adds unit tests covering DisableInternalCache behaviors and refresh-token exposure via extension.
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/SilentAuthTests.cs	Adds integration coverage ensuring refresh token can be retrieved while internal cache stays empty.
src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs	Skips all internal cache writes when `InternalCacheDisabled` is enabled.
src/client/Microsoft.Identity.Client/Cache/CacheSessionManager.cs	Short-circuits internal cache read operations when internal cache is disabled.
src/client/Microsoft.Identity.Client/Internal/Requests/Silent/CacheSilentStrategy.cs	Throws `internal_cache_disabled` when `AcquireTokenSilent` is used with internal cache disabled.
src/client/Microsoft.Identity.Client/Internal/Requests/RequestBase.cs	Populates internal refresh token on `AuthenticationResult` from `MsalTokenResponse`.
src/client/Microsoft.Identity.Client/Extensibility/AuthenticationResultExtensions.cs	Adds public extension API to retrieve refresh token.
src/client/Microsoft.Identity.Client/AuthenticationResult.cs	Adds internal `RefreshToken` property (not part of public surface).
src/client/Microsoft.Identity.Client/AppConfig/CacheOptions.cs	Adds `InternalCacheDisabled` + `DisableInternalCache` factory property.
src/client/Microsoft.Identity.Client/AppConfig/AbstractApplicationBuilder.cs	Validates mutual exclusivity of `UseSharedCache` and `InternalCacheDisabled`.
src/client/Microsoft.Identity.Client/MsalError.cs	Adds `MsalError.InternalCacheDisabled` constant.
src/client/Microsoft.Identity.Client/MsalErrorMessage.cs	Adds descriptive error message guiding callers to BYRT or interactive flows.
src/client/Microsoft.Identity.Client/PublicApi/*/PublicAPI.Unshipped.txt	Declares new public API surface across TFMs.

- Downgrade 'internal cache disabled' log in SaveTokenResponseAsync from Info to Verbose to avoid log noise in high-throughput apps - Remove unused 'using Microsoft.Identity.Test.Common;' from InternalCacheOptionsTests.cs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds support for disabling MSAL’s internal token cache and exposes refresh tokens (for confidential clients) via a public extension method to enable “bring your own cache” scenarios.

Changes:

Introduces CacheOptions.InternalCacheDisabled + CacheOptions.DisableInternalCache and enforces mutual exclusivity with UseSharedCache.
Prevents internal cache reads/writes when disabled and throws a dedicated MsalError.InternalCacheDisabled for AcquireTokenSilent.
Stores refresh tokens on AuthenticationResult (internal) and exposes them via AuthenticationResultExtensions.GetRefreshToken(), plus adds unit/integration tests and PublicAPI entries.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/Microsoft.Identity.Test.Unit/CacheTests/InternalCacheOptionsTests.cs	Adds unit tests for refresh token exposure and internal-cache-disabled behavior.
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/SilentAuthTests.cs	Adds integration test validating RT exposure + disabled-cache behavior in OBO.
src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs	Skips all cache writes when `InternalCacheDisabled` is set.
src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt	Declares new public API surface for netstandard2.0.
src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt	Declares new public API surface for net8.0.
src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt	Declares new public API surface for net8.0-ios.
src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt	Declares new public API surface for net8.0-android.
src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt	Declares new public API surface for net472.
src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt	Declares new public API surface for net462.
src/client/Microsoft.Identity.Client/MsalErrorMessage.cs	Adds a dedicated guidance message for internal-cache-disabled silent auth.
src/client/Microsoft.Identity.Client/MsalError.cs	Adds `MsalError.InternalCacheDisabled` constant + documentation.
src/client/Microsoft.Identity.Client/Internal/Requests/Silent/CacheSilentStrategy.cs	Throws `MsalClientException` when silent auth is attempted with cache disabled.
src/client/Microsoft.Identity.Client/Internal/Requests/RequestBase.cs	Captures refresh token into `AuthenticationResult` for confidential clients.
src/client/Microsoft.Identity.Client/Extensibility/AuthenticationResultExtensions.cs	New public extension method `GetRefreshToken()` to expose RT.
src/client/Microsoft.Identity.Client/Cache/CacheSessionManager.cs	Skips internal cache reads when `InternalCacheDisabled` is set.
src/client/Microsoft.Identity.Client/AuthenticationResult.cs	Adds internal `RefreshToken` storage on results.
src/client/Microsoft.Identity.Client/AppConfig/CacheOptions.cs	Adds `InternalCacheDisabled` and static factory `DisableInternalCache`.
src/client/Microsoft.Identity.Client/AppConfig/AbstractApplicationBuilder.cs	Validates `InternalCacheDisabled` and `UseSharedCache` are mutually exclusive.

gladjohn · 2026-04-24T18:23:32Z

copilot why did you commit this as a change? instead of a comment to the PR? 0e2e204

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR implements #5942 by exposing refresh tokens via a public extension method and introducing CacheOptions.DisableInternalCache to fully bypass MSAL’s internal token cache in advanced scenarios.

Changes:

Added an internal AuthenticationResult.RefreshToken and a public AuthenticationResultExtensions.GetRefreshToken() accessor.
Added CacheOptions.InternalCacheDisabled + CacheOptions.DisableInternalCache, and guarded internal cache reads/writes accordingly.
Added error code/message and tests (unit + integration) validating the new behavior.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/Microsoft.Identity.Test.Unit/CacheTests/InternalCacheOptionsTests.cs	Adds unit tests for refresh token exposure and internal cache disabling behavior.
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/SilentAuthTests.cs	Adds integration coverage for RT retrieval when internal cache is disabled.
src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs	Skips cache writes entirely when `InternalCacheDisabled` is enabled.
src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt	Declares new public API surface for netstandard2.0.
src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt	Declares new public API surface for net8.0.
src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt	Declares new public API surface for net8.0-ios.
src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt	Declares new public API surface for net8.0-android.
src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt	Declares new public API surface for net472.
src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt	Declares new public API surface for net462.
src/client/Microsoft.Identity.Client/MsalErrorMessage.cs	Adds error messages for internal cache disabled + mutual exclusivity.
src/client/Microsoft.Identity.Client/MsalError.cs	Adds `MsalError.InternalCacheDisabled` error code and docs.
src/client/Microsoft.Identity.Client/Internal/Requests/Silent/CacheSilentStrategy.cs	Throws `MsalUiRequiredException` early when internal cache is disabled.
src/client/Microsoft.Identity.Client/Internal/Requests/RequestBase.cs	Populates `AuthenticationResult.RefreshToken` for confidential-client flows.
src/client/Microsoft.Identity.Client/Extensibility/AuthenticationResultExtensions.cs	Introduces `GetRefreshToken()` extension method.
src/client/Microsoft.Identity.Client/Cache/CacheSessionManager.cs	Skips internal cache reads when disabled and returns null/empty defaults.
src/client/Microsoft.Identity.Client/AuthenticationResult.cs	Adds internal `RefreshToken` property.
src/client/Microsoft.Identity.Client/AppConfig/CacheOptions.cs	Adds `InternalCacheDisabled` and `DisableInternalCache` factory property.
src/client/Microsoft.Identity.Client/AppConfig/AbstractApplicationBuilder.cs	Validates mutual exclusivity of `InternalCacheDisabled` and `UseSharedCache`.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Implements #5942 by exposing refresh tokens (via an extension method) and adding CacheOptions.DisableInternalCache to disable MSAL’s internal token cache reads/writes, with corresponding builder validation and error signaling for unsupported silent flows.

Changes:

Expose refresh token on AuthenticationResult (internally) and via AuthenticationResultExtensions.GetRefreshToken().
Add CacheOptions.InternalCacheDisabled + CacheOptions.DisableInternalCache and enforce behavior across cache reads/writes and silent strategy.
Add/update unit + integration tests and update PublicAPI surface files.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tests/Microsoft.Identity.Test.Unit/CacheTests/InternalCacheOptionsTests.cs	Adds unit tests for refresh token exposure and internal-cache-disabled behavior/validation.
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/SilentAuthTests.cs	Adds integration coverage for refresh-token exposure when internal cache is disabled.
src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs	Skips all cache writes when internal cache is disabled.
src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt	Records new public API surface for netstandard2.0.
src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt	Records new public API surface for net8.0.
src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt	Records new public API surface for net8.0-ios.
src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt	Records new public API surface for net8.0-android.
src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt	Records new public API surface for net472.
src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt	Records new public API surface for net462.
src/client/Microsoft.Identity.Client/MsalErrorMessage.cs	Adds guidance messages for internal-cache-disabled scenarios and mutual exclusivity.
src/client/Microsoft.Identity.Client/MsalError.cs	Adds `MsalError.InternalCacheDisabled` constant and docs.
src/client/Microsoft.Identity.Client/Internal/Requests/Silent/CacheSilentStrategy.cs	Throws a targeted `MsalUiRequiredException` when internal cache is disabled.
src/client/Microsoft.Identity.Client/Internal/Requests/RequestBase.cs	Captures refresh token in `AuthenticationResult` for confidential clients.
src/client/Microsoft.Identity.Client/Extensibility/AuthenticationResultExtensions.cs	Introduces `GetRefreshToken()` extension method.
src/client/Microsoft.Identity.Client/Cache/CacheSessionManager.cs	Skips cache reads when internal cache is disabled.
src/client/Microsoft.Identity.Client/AuthenticationResult.cs	Adds internal `RefreshToken` storage on `AuthenticationResult`.
src/client/Microsoft.Identity.Client/AppConfig/CacheOptions.cs	Adds `InternalCacheDisabled` option and `DisableInternalCache` factory property.
src/client/Microsoft.Identity.Client/AppConfig/AbstractApplicationBuilder.cs	Validates mutual exclusivity of `UseSharedCache` and `InternalCacheDisabled`.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…s XML doc Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated no new comments.

bgavrilMS

Approved with 1 comment

gladjohn

Approved - Please get a sign off from @neha-bhargava for client-side telemetry before merging this in

…public client Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…_refresh_token_and_add_disableInternalCache

gladjohn

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

… or response Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 6 comments.

…PI append-only ordering Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 23, 2026 21:25

Robbie-Microsoft requested a review from a team as a code owner April 23, 2026 21:25

Robbie-Microsoft linked an issue Apr 23, 2026 that may be closed by this pull request

[Feature Request] Expose refresh token via extension method and add CacheOptions.DisableInternalCache #5942

Closed

9 tasks

Copilot started reviewing on behalf of Robbie-Microsoft April 23, 2026 21:26 View session

Robbie-Microsoft changed the title ~~mTLS Pop: expose refresh token via extension and add CacheOptions.DisableInternalCache~~ Expose refresh token via extension and add CacheOptions.DisableInternalCache Apr 23, 2026

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread src/client/Microsoft.Identity.Client/Cache/CacheSessionManager.cs Outdated

Comment thread src/client/Microsoft.Identity.Client/Cache/CacheSessionManager.cs Outdated

Comment thread tests/Microsoft.Identity.Test.Unit/CacheTests/InternalCacheOptionsTests.cs Outdated

bgavrilMS reviewed Apr 24, 2026

View reviewed changes

Comment thread src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs Outdated

bgavrilMS approved these changes Apr 24, 2026

View reviewed changes

gladjohn approved these changes Apr 24, 2026

View reviewed changes

gladjohn reviewed Apr 24, 2026

View reviewed changes

Comment thread src/client/Microsoft.Identity.Client/Extensibility/AuthenticationResultExtensions.cs

Kushagratrivedi reviewed Apr 24, 2026

View reviewed changes

Comment thread src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs Outdated

Copilot AI review requested due to automatic review settings April 24, 2026 16:42

Copilot started reviewing on behalf of Robbie-Microsoft April 24, 2026 16:43 View session

gladjohn reviewed Apr 24, 2026

View reviewed changes

Comment thread src/client/Microsoft.Identity.Client/Internal/Requests/RequestBase.cs Outdated

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Comment thread src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs Outdated

Comment thread src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs

Comment thread tests/Microsoft.Identity.Test.Unit/CacheTests/InternalCacheOptionsTests.cs Outdated

bgavrilMS reviewed Apr 24, 2026

View reviewed changes

Comment thread tests/Microsoft.Identity.Test.Unit/CacheTests/InternalCacheOptionsTests.cs Outdated

bgavrilMS reviewed Apr 24, 2026

View reviewed changes

Comment thread tests/Microsoft.Identity.Test.Unit/CacheTests/InternalCacheOptionsTests.cs Outdated

Copilot AI review requested due to automatic review settings April 24, 2026 17:41

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Copilot started reviewing on behalf of Robbie-Microsoft April 24, 2026 17:50 View session

gladjohn reviewed Apr 24, 2026

View reviewed changes

Comment thread src/client/Microsoft.Identity.Client/AppConfig/AbstractApplicationBuilder.cs Outdated

gladjohn reviewed Apr 24, 2026

View reviewed changes

Comment thread src/client/Microsoft.Identity.Client/Cache/CacheSessionManager.cs

Copilot AI review requested due to automatic review settings April 24, 2026 18:20

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Comment thread src/client/Microsoft.Identity.Client/Cache/CacheSessionManager.cs

Comment thread src/client/Microsoft.Identity.Client/MsalError.cs Outdated

Comment thread src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs Outdated

Copilot AI review requested due to automatic review settings April 24, 2026 18:32

Copilot started reviewing on behalf of gladjohn April 24, 2026 18:35 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Update src/client/Microsoft.Identity.Client/MsalErrorMessage.cs

246a214

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 29, 2026 22:58

Update src/client/Microsoft.Identity.Client/MsalError.cs

77f2e1f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of Robbie-Microsoft April 29, 2026 22:59 View session

Robbie-Microsoft requested a review from neha-bhargava April 29, 2026 23:00

Fix: fully-qualify CacheOptions cref in AuthenticationResultExtension…

a7e7ec4

…s XML doc Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI reviewed Apr 29, 2026

View reviewed changes

bgavrilMS reviewed Apr 30, 2026

View reviewed changes

Comment thread tests/Microsoft.Identity.Test.Unit/CacheTests/InternalCacheOptionsTests.cs Outdated

bgavrilMS approved these changes Apr 30, 2026

View reviewed changes

gladjohn approved these changes Apr 30, 2026

View reviewed changes

Robbie-Microsoft and others added 2 commits April 30, 2026 13:09

Fix: throw at config time when DisableInternalCacheOptions is set on …

18a544c

…public client Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into rginsburg/mtls_expose…

98682d1

…_refresh_token_and_add_disableInternalCache

Copilot AI review requested due to automatic review settings April 30, 2026 17:15

Copilot started reviewing on behalf of Robbie-Microsoft April 30, 2026 17:15 View session

bgavrilMS approved these changes Apr 30, 2026

View reviewed changes

gladjohn approved these changes Apr 30, 2026

View reviewed changes

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread src/client/Microsoft.Identity.Client/AppConfig/AbstractApplicationBuilder.cs Outdated

Comment thread src/client/Microsoft.Identity.Client/Extensibility/AuthenticationResultExtensions.cs Outdated

Fix: update GetRefreshToken() doc to reflect RT may come from request…

2f11fe9

… or response Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Robbie-Microsoft enabled auto-merge (squash) April 30, 2026 17:28

bgavrilMS approved these changes Apr 30, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 30, 2026 18:08

Merge main into branch; resolve PublicAPI.Unshipped.txt conflicts

3d12ae1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

gladjohn approved these changes Apr 30, 2026

View reviewed changes

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Fix: remove redundant null check in WithCacheOptions; restore PublicA…

7f12f0c

…PI append-only ordering Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of Robbie-Microsoft April 30, 2026 18:59 View session

gladjohn approved these changes Apr 30, 2026

View reviewed changes

Robbie-Microsoft merged commit d96b4f0 into main Apr 30, 2026
15 checks passed

Robbie-Microsoft deleted the rginsburg/mtls_expose_refresh_token_and_add_disableInternalCache branch April 30, 2026 20:36

gladjohn mentioned this pull request May 1, 2026

[Engineering task] Copilot PR Review: excessive noise from review_on_push and false positives #5967

Open

Conversation

Robbie-Microsoft commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Deliverable 1: Expose refresh token via extension method

Deliverable 2: CacheOptions.DisableInternalCacheOptions

Other changes

Tests

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bgavrilMS left a comment

Choose a reason for hiding this comment

Uh oh!

gladjohn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gladjohn commented Apr 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

bgavrilMS left a comment

Choose a reason for hiding this comment

Uh oh!

gladjohn left a comment

Choose a reason for hiding this comment

Uh oh!

gladjohn left a comment

Robbie-Microsoft commented Apr 23, 2026 •

edited

Loading

Deliverable 2: `CacheOptions.DisableInternalCacheOptions`